Nodarx/server
1
0
Fork 0
Code Issues 1 Pull Requests 5 Actions Projects Releases Activity

refactor(security): replace generic event with severity enum

Browse Source 
Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>
This commit is contained in:
Sebastian Krupinski
2026-08-05 23:59:49 -04:00
parent 3f9c2500d9
commit 84eb0e2c21
27 changed files with 80 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/php/Unit/Event/AccessDeniedEventTest.php
+2 -2
View File
@@ -6,7 +6,7 @@ namespace KTXT\Unit\Event;
use KTXC\Models\Firewall\FirewallRuleObject;
use KTXC\Security\Event\AccessDeniedEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -35,7 +35,7 @@ final class AccessDeniedEventTest extends TestCase
self::assertSame('Blocked by policy', $event->getReason());
self::assertSame('tenant-a', $event->getTenantId());
self::assertSame('identity-a', $event->getIdentityId());
self::assertSame(SecurityEvent::SEVERITY_WARNING, $event->getSeverity());
self::assertSame(SecurityEventSeverity::WARNING, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/AuthenticationFailedEventTest.php
+2 -2
View File
@@ -5,7 +5,7 @@ declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\AuthenticationFailedEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use KTXC\Security\Event\SecurityRequestEventInterface;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
@@ -29,7 +29,7 @@ final class AuthenticationFailedEventTest extends TestCase
self::assertSame('Invalid credentials', $event->getReason());
self::assertSame('tenant-a', $event->getTenantId());
self::assertSame('identity-a', $event->getIdentityId());
self::assertSame(SecurityEvent::SEVERITY_WARNING, $event->getSeverity());
self::assertSame(SecurityEventSeverity::WARNING, $event->getSeverity());
self::assertNotInstanceOf(SecurityRequestEventInterface::class, $event);
}
}
tests/php/Unit/Event/AuthenticationSucceededEventTest.php
+2 -2
View File
@@ -5,7 +5,7 @@ declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\AuthenticationSucceededEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -29,7 +29,7 @@ final class AuthenticationSucceededEventTest extends TestCase
self::assertSame('tenant-a', $event->getTenantId());
self::assertSame('device-a', $event->getDeviceFingerprint());
self::assertSame(['userId' => 'user-a'], $event->getData());
self::assertSame(SecurityEvent::SEVERITY_INFO, $event->getSeverity());
self::assertSame(SecurityEventSeverity::INFO, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/BruteForceDetectedEventTest.php
+2 -2
View File
@@ -5,7 +5,7 @@ declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\BruteForceDetectedEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -33,7 +33,7 @@ final class BruteForceDetectedEventTest extends TestCase
['failureCount' => 5, 'windowSeconds' => 300],
$event->getData(),
);
self::assertSame(SecurityEvent::SEVERITY_CRITICAL, $event->getSeverity());
self::assertSame(SecurityEventSeverity::CRITICAL, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/FirewallPolicyEventTest.php
+5 -5
View File
@@ -8,7 +8,7 @@ use KTXC\Security\Event\DeviceBlockedEvent;
use KTXC\Security\Event\FirewallSettingsUpdatedEvent;
use KTXC\Security\Event\IpAllowedEvent;
use KTXC\Security\Event\IpBlockedEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -26,13 +26,13 @@ final class FirewallPolicyEventTest extends TestCase
self::assertSame(IpBlockedEvent::class, $blocked->getName());
self::assertSame('203.0.113.10', $blocked->getIpAddress());
self::assertSame('Repeated abuse', $blocked->getReason());
self::assertSame(SecurityEvent::SEVERITY_CRITICAL, $blocked->getSeverity());
self::assertSame(SecurityEventSeverity::CRITICAL, $blocked->getSeverity());
self::assertSame(IpAllowedEvent::class, $allowed->getName());
self::assertSame('203.0.113.11', $allowed->getIpAddress());
self::assertSame(SecurityEvent::SEVERITY_INFO, $allowed->getSeverity());
self::assertSame(SecurityEventSeverity::INFO, $allowed->getSeverity());
self::assertSame(DeviceBlockedEvent::class, $device->getName());
self::assertSame('device-a', $device->getDeviceFingerprint());
self::assertSame(SecurityEvent::SEVERITY_CRITICAL, $device->getSeverity());
self::assertSame(SecurityEventSeverity::CRITICAL, $device->getSeverity());
}
#[Test]
@@ -54,7 +54,7 @@ final class FirewallPolicyEventTest extends TestCase
self::assertSame('tenant-a', $event->getTenantId());
self::assertSame('operator-a', $event->getIdentityId());
self::assertSame('manual', $event->getChangeOrigin());
self::assertSame(SecurityEvent::SEVERITY_INFO, $event->getSeverity());
self::assertSame(SecurityEventSeverity::INFO, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/FirewallRuleEventTest.php
+2 -2
View File
@@ -10,7 +10,7 @@ use KTXC\Security\Event\FirewallRuleDisabledEvent;
use KTXC\Security\Event\FirewallRuleEnabledEvent;
use KTXC\Security\Event\FirewallRuleExtendedEvent;
use KTXC\Security\Event\FirewallRuleRemovedEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -54,7 +54,7 @@ final class FirewallRuleEventTest extends TestCase
self::assertSame('operator-a', $event->getIdentityId());
self::assertSame(5, $event->get('failureCount'));
self::assertSame('Continue monitoring', $event->get('changeReason'));
self::assertSame(SecurityEvent::SEVERITY_INFO, $event->getSeverity());
self::assertSame(SecurityEventSeverity::INFO, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/RateLimitExceededEventTest.php
+2 -2
View File
@@ -5,7 +5,7 @@ declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\RateLimitExceededEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
@@ -32,7 +32,7 @@ final class RateLimitExceededEventTest extends TestCase
self::assertSame('/login', $event->getRequestPath());
self::assertSame('tenant-a', $event->getTenantId());
self::assertSame('101 requests in 60 seconds', $event->getReason());
self::assertSame(SecurityEvent::SEVERITY_ERROR, $event->getSeverity());
self::assertSame(SecurityEventSeverity::ERROR, $event->getSeverity());
}
#[Test]
tests/php/Unit/Event/SecurityEventSeverityTest.php
+24
View File
@@ -0,0 +1,24 @@
<?php
declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\SecurityEventSeverity;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
final class SecurityEventSeverityTest extends TestCase
{
#[Test]
#[TestDox('Security severity levels expose stable numeric values')]
public function exposesStableNumericValues(): void
{
self::assertSame(0, SecurityEventSeverity::DEBUG->value);
self::assertSame(1, SecurityEventSeverity::INFO->value);
self::assertSame(2, SecurityEventSeverity::WARNING->value);
self::assertSame(3, SecurityEventSeverity::ERROR->value);
self::assertSame(4, SecurityEventSeverity::CRITICAL->value);
}
}
tests/php/Unit/Event/SecurityEventTest.php
-60
View File
@@ -1,60 +0,0 @@
<?php
declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\SecurityEvent;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\TestCase;
final class SecurityEventTest extends TestCase
{
#[Test]
#[TestDox('Direct construction applies the event type default severity')]
public function appliesDefaultSeverityDuringConstruction(): void
{
self::assertSame(
SecurityEvent::SEVERITY_WARNING,
(new SecurityEvent(SecurityEvent::AUTH_LOGOUT))->getSeverity(),
);
self::assertSame(
SecurityEvent::SEVERITY_INFO,
(new SecurityEvent(SecurityEvent::ACCESS_GRANTED))->getSeverity(),
);
}
#[Test]
#[TestDox('Construction can override the event type default severity')]
public function allowsSeverityOverride(): void
{
$event = new SecurityEvent(
SecurityEvent::AUTH_LOGOUT,
severity: SecurityEvent::SEVERITY_CRITICAL,
);
self::assertSame(SecurityEvent::SEVERITY_CRITICAL, $event->getSeverity());
}
#[Test]
#[TestDox('Event state exposes no mutation methods')]
public function exposesNoMutationMethods(): void
{
foreach ([
'set',
'setTenantId',
'setIdentityId',
'setIpAddress',
'setDeviceFingerprint',
'setUserAgent',
'setRequestPath',
'setRequestMethod',
'setUserId',
'setReason',
'setSeverity',
] as $method) {
self::assertFalse(method_exists(SecurityEvent::class, $method));
}
}
}
tests/php/Unit/Event/SuspiciousActivityEventTest.php
+2 -2
View File
@@ -4,7 +4,7 @@ declare(strict_types=1);
namespace KTXT\Unit\Event;
use KTXC\Security\Event\SecurityEvent;
use KTXC\Security\Event\SecurityEventSeverity;
use KTXC\Security\Event\SuspiciousActivityEvent;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;
@@ -43,7 +43,7 @@ final class SuspiciousActivityEventTest extends TestCase
self::assertSame('POST', $event->getRequestMethod());
self::assertSame('user-a', $event->getUserId());
self::assertSame('Matched a blocked payload signature', $event->getReason());
self::assertSame(SecurityEvent::SEVERITY_ERROR, $event->getSeverity());
self::assertSame(SecurityEventSeverity::ERROR, $event->getSeverity());
}
#[Test]
tests/php/Unit/Module/CoreModuleTest.php
-1
View File
@@ -28,7 +28,6 @@ use KTXC\Security\Event\FirewallRuleRemovedEvent;
use KTXC\Security\Event\FirewallSettingsUpdatedEvent;
use KTXC\Security\Event\RateLimitExceededEvent;
use KTXC\Security\Event\SuspiciousActivityEvent;
use KTXC\Security\Event\SecurityEvent;
use KTXF\Event\DeliveryMode;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\Attributes\TestDox;