refactor(security): add typed access-denied event

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>

tests/php/Unit/Service/FirewallServiceTest.php

@@ -10,6 +10,7 @@ use KTXC\Http\Request\RequestContext;
 use KTXC\Models\Firewall\FirewallRuleObject;
 use KTXC\Models\Firewall\FirewallLogObject;
 use KTXC\Models\Tenant\TenantConfiguration;
+use KTXC\Security\Event\AccessDeniedEvent;
 use KTXC\Security\Event\AuthenticationFailedEvent;
 use KTXC\Security\Event\BruteForceDetectedEvent;
 use KTXC\Service\FirewallService;
@@ -86,7 +87,15 @@ class FirewallServiceTest extends TestCase
 
         $this->store->expects($this->once())->method('listSystemRules')->willReturn([$systemBlock]);
         $this->store->expects($this->once())->method('listRules')->with('tenant-a')->willReturn([$tenantAllow]);
-        $this->events->expects($this->once())->method('dispatch');
+        $this->events->expects($this->once())
+            ->method('dispatch')
+            ->with(self::callback(static function ($event): bool {
+                return $event instanceof AccessDeniedEvent
+                    && $event->getIpAddress() === '203.0.113.10'
+                    && $event->getRuleId() === 'system-block'
+                    && $event->getRuleScope() === FirewallRuleObject::SCOPE_SYSTEM
+                    && $event->getReason() === 'system-block';
+            }));
 
         $result = $this->service->analyze('203.0.113.10');
 
@@ -226,13 +235,12 @@ class FirewallServiceTest extends TestCase
                     && $log->getEventType() === FirewallLogObject::EVENT_RULE_MATCH;
             }))
             ->willReturnArgument(0);
-        $event = \KTXC\Security\Event\SecurityEvent::accessDenied(
-            '203.0.113.10',
-            null,
-            'tenant-rule',
-            FirewallRuleObject::SCOPE_TENANT,
-            'Tenant block',
-            'tenant-a',
+        $event = new AccessDeniedEvent(
+            ipAddress: '203.0.113.10',
+            ruleId: 'tenant-rule',
+            ruleScope: FirewallRuleObject::SCOPE_TENANT,
+            reason: 'Tenant block',
+            tenantId: 'tenant-a',
         );
 
         $this->service->logSecurityEvent($event);
@@ -250,12 +258,11 @@ class FirewallServiceTest extends TestCase
                     && $log->getRuleScope() === FirewallRuleObject::SCOPE_SYSTEM;
             }))
             ->willReturnArgument(0);
-        $event = \KTXC\Security\Event\SecurityEvent::accessDenied(
-            '203.0.113.10',
-            null,
-            'system-rule',
-            FirewallRuleObject::SCOPE_SYSTEM,
-            'System block'
+        $event = new AccessDeniedEvent(
+            ipAddress: '203.0.113.10',
+            ruleId: 'system-rule',
+            ruleScope: FirewallRuleObject::SCOPE_SYSTEM,
+            reason: 'System block',
         );
 
         $this->service->logSecurityEvent($event);