refactor(security): add typed rate-limit event

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>

tests/php/Unit/Event/RateLimitExceededEventTest.php

@@ -0,0 +1,56 @@
+<?php
+
+declare(strict_types=1);
+
+namespace KTXT\Unit\Event;
+
+use KTXC\Security\Event\RateLimitExceededEvent;
+use KTXC\Security\Event\SecurityEvent;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\Attributes\TestDox;
+use PHPUnit\Framework\TestCase;
+
+final class RateLimitExceededEventTest extends TestCase
+{
+    #[Test]
+    #[TestDox('Rate-limit state is typed and complete at construction')]
+    public function constructsTypedState(): void
+    {
+        $event = new RateLimitExceededEvent(
+            '203.0.113.10',
+            101,
+            60,
+            '/login',
+            'tenant-a',
+        );
+
+        self::assertSame(RateLimitExceededEvent::class, $event->getName());
+        self::assertSame('203.0.113.10', $event->getIpAddress());
+        self::assertSame(101, $event->getRequestCount());
+        self::assertSame(60, $event->getWindowSeconds());
+        self::assertSame('/login', $event->getEndpoint());
+        self::assertSame('/login', $event->getRequestPath());
+        self::assertSame('tenant-a', $event->getTenantId());
+        self::assertSame('101 requests in 60 seconds', $event->getReason());
+        self::assertSame(SecurityEvent::SEVERITY_ERROR, $event->getSeverity());
+    }
+
+    #[Test]
+    #[TestDox('Rate-limit detection rejects invalid measurements')]
+    public function rejectsInvalidMeasurements(): void
+    {
+        foreach ([
+            ['', 101, 60, '/login'],
+            ['203.0.113.10', 0, 60, '/login'],
+            ['203.0.113.10', 101, 0, '/login'],
+            ['203.0.113.10', 101, 60, ''],
+        ] as $arguments) {
+            try {
+                new RateLimitExceededEvent(...$arguments);
+                self::fail('Invalid rate-limit measurements were accepted.');
+            } catch (\InvalidArgumentException) {
+                $this->addToAssertionCount(1);
+            }
+        }
+    }
+}

tests/php/Unit/Event/SecurityEventTest.php

@@ -21,7 +21,7 @@ final class SecurityEventTest extends TestCase
         );
         self::assertSame(
             SecurityEvent::SEVERITY_ERROR,
-            (new SecurityEvent(SecurityEvent::RATE_LIMIT_EXCEEDED))->getSeverity(),
+            (new SecurityEvent(SecurityEvent::SUSPICIOUS_ACTIVITY))->getSeverity(),
         );
         self::assertSame(
             SecurityEvent::SEVERITY_CRITICAL,

tests/php/Unit/Module/CoreModuleTest.php

@@ -19,6 +19,7 @@ use KTXC\Event\EventListenerRegistry;
 use KTXC\Security\Event\AccessDeniedEvent;
 use KTXC\Security\Event\AuthenticationFailedEvent;
 use KTXC\Security\Event\BruteForceDetectedEvent;
+use KTXC\Security\Event\RateLimitExceededEvent;
 use KTXC\Security\Event\SecurityEvent;
 use KTXF\Event\DeliveryMode;
 use PHPUnit\Framework\Attributes\Test;
@@ -47,7 +48,7 @@ final class CoreModuleTest extends TestCase
         foreach ([
             AccessDeniedEvent::class,
             BruteForceDetectedEvent::class,
-            SecurityEvent::RATE_LIMIT_EXCEEDED,
+            RateLimitExceededEvent::class,
             SecurityEvent::SUSPICIOUS_ACTIVITY,
             SecurityEvent::FIREWALL_RULE_CREATED,
             SecurityEvent::FIREWALL_RULE_EXTENDED,

tests/php/Unit/Service/FirewallServiceTest.php

@@ -13,6 +13,7 @@ use KTXC\Models\Tenant\TenantConfiguration;
 use KTXC\Security\Event\AccessDeniedEvent;
 use KTXC\Security\Event\AuthenticationFailedEvent;
 use KTXC\Security\Event\BruteForceDetectedEvent;
+use KTXC\Security\Event\RateLimitExceededEvent;
 use KTXC\Service\FirewallService;
 use KTXC\Service\FirewallRuleCache;
 use KTXC\Service\FirewallRuleManager;
@@ -294,7 +295,7 @@ class FirewallServiceTest extends TestCase
                     && $metadata['windowSeconds'] === 60;
             }))
             ->willReturnArgument(0);
-        $event = \KTXC\Security\Event\SecurityEvent::rateLimitExceeded(
+        $event = new RateLimitExceededEvent(
             '203.0.113.10',
             101,
             60,