refactor(security): type firewall policy events

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>

tests/php/Unit/Service/FirewallRuleManagerTest.php

@@ -16,6 +16,9 @@ use KTXC\Security\Event\FirewallRuleDisabledEvent;
 use KTXC\Security\Event\FirewallRuleEnabledEvent;
 use KTXC\Security\Event\FirewallRuleExtendedEvent;
 use KTXC\Security\Event\FirewallRuleRemovedEvent;
+use KTXC\Security\Event\DeviceBlockedEvent;
+use KTXC\Security\Event\IpAllowedEvent;
+use KTXC\Security\Event\IpBlockedEvent;
 use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\MockObject\MockObject;
@@ -301,6 +304,42 @@ class FirewallRuleManagerTest extends TestCase
         self::assertSame(FirewallRuleManager::ORIGIN_MANUAL, $audit->get('origin'));
         self::assertSame('admin-a', $audit->getIdentityId());
         self::assertNotNull($audit->get('expiresAt'));
+        self::assertInstanceOf(IpBlockedEvent::class, $events[IpBlockedEvent::class]);
+        self::assertSame('203.0.113.10', $events[IpBlockedEvent::class]->getIpAddress());
+    }
+
+    #[TestDox('IP allowance and device blocking publish dedicated policy events')]
+    public function testSubjectPolicyEvents(): void
+    {
+        $this->store->method('findExactIpRule')->willReturn(null);
+        $this->store->method('depositRule')->willReturnCallback(
+            static function (FirewallRuleObject $rule): FirewallRuleObject {
+                static $sequence = 0;
+                return $rule->setId('policy-rule-' . ++$sequence);
+            }
+        );
+        $events = [];
+        $this->events->expects($this->exactly(4))
+            ->method('dispatch')
+            ->willReturnCallback(static function (\KTXF\Event\Event $event) use (&$events): void {
+                $events[] = $event;
+            });
+
+        $this->manager->allowIp(
+            FirewallRuleScope::tenant('tenant-a'),
+            '203.0.113.11',
+            'Trusted service',
+            'admin-a',
+        );
+        $this->manager->blockDevice(
+            FirewallRuleScope::tenant('tenant-a'),
+            'device-a',
+            'Compromised device',
+            'admin-a',
+        );
+
+        self::assertCount(1, array_filter($events, static fn($event): bool => $event instanceof IpAllowedEvent));
+        self::assertCount(1, array_filter($events, static fn($event): bool => $event instanceof DeviceBlockedEvent));
     }
 
     #[TestDox('Manual lifecycle changes persist state, reasons, actors, and extension history')]

tests/php/Unit/Service/FirewallServiceTest.php

@@ -16,6 +16,7 @@ use KTXC\Security\Event\AuthenticationSucceededEvent;
 use KTXC\Security\Event\BruteForceDetectedEvent;
 use KTXC\Security\Event\FirewallRuleCreatedEvent;
 use KTXC\Security\Event\FirewallRuleDisabledEvent;
+use KTXC\Security\Event\FirewallSettingsUpdatedEvent;
 use KTXC\Security\Event\RateLimitExceededEvent;
 use KTXC\Security\Event\SuspiciousActivityEvent;
 use KTXC\Service\FirewallService;
@@ -396,11 +397,12 @@ class FirewallServiceTest extends TestCase
                 && $log->getMetadata()['changeReason'] === 'Tighten controls'
             ))
             ->willReturnArgument(0);
-        $event = new \KTXC\Security\Event\SecurityEvent(
-            \KTXC\Security\Event\SecurityEvent::FIREWALL_SETTINGS_UPDATED,
-            ['changeReason' => 'Tighten controls'],
+        $event = new FirewallSettingsUpdatedEvent(
+            changeReason: 'Tighten controls',
+            previous: ['maxAuthFailures' => 5],
+            current: ['maxAuthFailures' => 3],
             tenantId: 'tenant-a',
-            identityId: 'operator',
+            actorId: 'operator',
         );
 
         $this->service->logSecurityEvent($event);

tests/php/Unit/Service/FirewallSettingsServiceTest.php

@@ -9,7 +9,7 @@ use KTXC\Models\Tenant\TenantObject;
 use KTXC\Service\FirewallSettingsService;
 use KTXC\Service\TenantService;
 use KTXF\Event\EventDispatcherInterface;
-use KTXC\Security\Event\SecurityEvent;
+use KTXC\Security\Event\FirewallSettingsUpdatedEvent;
 use PHPUnit\Framework\Attributes\TestDox;
 use PHPUnit\Framework\TestCase;
 
@@ -37,8 +37,8 @@ final class FirewallSettingsServiceTest extends TestCase
         $events = $this->createMock(EventDispatcherInterface::class);
         $events->expects(self::once())
             ->method('dispatch')
-            ->with(self::callback(static fn(SecurityEvent $event): bool =>
-                $event->getName() === SecurityEvent::FIREWALL_SETTINGS_UPDATED
+            ->with(self::callback(static fn(FirewallSettingsUpdatedEvent $event): bool =>
+                $event->getName() === FirewallSettingsUpdatedEvent::class
                 && $event->getTenantId() === 'tenant-a'
                 && $event->getIdentityId() === 'admin-a'
                 && $event->get('changeReason') === 'Tighten authentication controls'