refactor(security): type firewall rule lifecycle events

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>

tests/php/Unit/Service/FirewallServiceTest.php

@@ -14,6 +14,8 @@ use KTXC\Security\Event\AccessDeniedEvent;
 use KTXC\Security\Event\AuthenticationFailedEvent;
 use KTXC\Security\Event\AuthenticationSucceededEvent;
 use KTXC\Security\Event\BruteForceDetectedEvent;
+use KTXC\Security\Event\FirewallRuleCreatedEvent;
+use KTXC\Security\Event\FirewallRuleDisabledEvent;
 use KTXC\Security\Event\RateLimitExceededEvent;
 use KTXC\Security\Event\SuspiciousActivityEvent;
 use KTXC\Service\FirewallService;
@@ -367,14 +369,15 @@ class FirewallServiceTest extends TestCase
                     && $log->getIdentityId() === 'operator';
             }))
             ->willReturnArgument(0);
-        $event = new \KTXC\Security\Event\SecurityEvent(
-            \KTXC\Security\Event\SecurityEvent::FIREWALL_RULE_DISABLED,
-            [
-                'ruleId' => 'rule-123',
-                'ruleScope' => FirewallRuleObject::SCOPE_SYSTEM,
-                'origin' => FirewallRuleManager::ORIGIN_MANUAL,
-            ],
-            identityId: 'operator',
+        $event = FirewallRuleDisabledEvent::fromRule(
+            (new FirewallRuleObject())
+                ->setId('rule-123')
+                ->setScope(FirewallRuleObject::SCOPE_SYSTEM)
+                ->setType(FirewallRuleObject::TYPE_IP)
+                ->setAction(FirewallRuleObject::ACTION_BLOCK)
+                ->setValue('203.0.113.10')
+                ->setMetadata(['origin' => FirewallRuleManager::ORIGIN_MANUAL]),
+            'operator',
         );
 
         $this->service->logSecurityEvent($event);
@@ -521,7 +524,9 @@ class FirewallServiceTest extends TestCase
                     && $metadata['lastFailureCount'] === 5
                     && $metadata['blockDurationSeconds'] === 3600;
             }))
-            ->willReturnArgument(0);
+            ->willReturnCallback(static fn(FirewallRuleObject $rule): FirewallRuleObject =>
+                $rule->setId('automatic-rule')
+            );
 
         $publishedTenants = [];
         $lifecycleOrigin = null;
@@ -537,7 +542,7 @@ class FirewallServiceTest extends TestCase
                 if ($event instanceof BruteForceDetectedEvent) {
                     $bruteForceEvent = $event;
                 }
-                if ($event->getName() === \KTXC\Security\Event\SecurityEvent::FIREWALL_RULE_CREATED) {
+                if ($event instanceof FirewallRuleCreatedEvent) {
                     $lifecycleOrigin = $event->get('origin');
                 }
             });