chore(deps): update dependency phpunit/phpunit to v13

composer.json

@@ -31,7 +31,7 @@
     "sebastiankrupinski/jmap-client-php": "dev-main"
   },
   "require-dev": {
-    "phpunit/phpunit": "^12.0"
+    "phpunit/phpunit": "^13.0"
   },
   "autoload": {
     "psr-4": {

lib/Providers/Mail/Provider.php

@@ -9,7 +9,6 @@ declare(strict_types=1);
 
 namespace KTXM\ProviderJmapc\Providers\Mail;
 
-use KTXF\Mail\Object\Address;
 use KTXF\Mail\Provider\ProviderBaseInterface;
 use KTXF\Mail\Provider\ProviderServiceDiscoverInterface;
 use KTXF\Mail\Provider\ProviderServiceMutateInterface;
@@ -143,66 +142,9 @@ class Provider implements ProviderBaseInterface, ProviderServiceMutateInterface,
         }
 
         $created = $this->serviceStore->create($tenantId, $userId, $service);
-        $this->serviceIdentitiesSync($tenantId, $userId, (new Service())->fromStore($created));
         return (string) $created['sid'];
     }
 
-    /**
-     * Fetches sending identities from the JMAP server and overwrites
-     * primaryAddress/secondaryAddresses on the service with them.
-     */
-    private function serviceIdentitiesSync(string $tenantId, string $userId, Service $service): void
-    {
-        try {
-            $client = RemoteService::freshClient($service);
-            $identities = RemoteService::mailService($client)->identityFetch();
-
-            // A JMAP server may expose multiple identities sharing the same
-            // address (e.g. distinct signatures/display names for one
-            // mailbox) — collapse those down to one entry per address,
-            // keeping the first label seen.
-            $addresses = [];
-            foreach ($identities as $identity) {
-                if ($identity->address() === null) {
-                    continue;
-                }
-                $key = strtolower($identity->address());
-                if (!isset($addresses[$key])) {
-                    $addresses[$key] = Address::fromArray(['address' => $identity->address(), 'label' => $identity->name()]);
-                }
-            }
-            $addresses = array_values($addresses);
-
-            if (empty($addresses)) {
-                return;
-            }
-
-            $currentAddress = strtolower($service->getPrimaryAddress()->getAddress());
-            $primaryIndex = 0;
-            foreach ($addresses as $index => $address) {
-                if (strtolower($address->getAddress()) === $currentAddress) {
-                    $primaryIndex = $index;
-                    break;
-                }
-            }
-
-            $secondary = [];
-            foreach ($addresses as $index => $address) {
-                if ($index !== $primaryIndex) {
-                    $secondary[] = $address;
-                }
-            }
-
-            $service->setPrimaryAddress($addresses[$primaryIndex]);
-            $service->setSecondaryAddresses($secondary);
-
-            $this->serviceStore->modify($tenantId, $userId, $service);
-        } catch (\Throwable) {
-            // Server may not support urn:ietf:params:jmap:submission, or have
-            // no identities configured — fall back to what the user entered.
-        }
-    }
-
     public function serviceModify(string $tenantId, string $userId, ResourceServiceMutateInterface $service): string
     {
         if (!($service instanceof Service)) {
@@ -210,7 +152,6 @@ class Provider implements ProviderBaseInterface, ProviderServiceMutateInterface,
         }
 
         $this->serviceStore->modify($tenantId, $userId, $service);
-        $this->serviceIdentitiesSync($tenantId, $userId, $service);
         return (string) $service->identifier();
     }
 

lib/Providers/Mail/Service.php

@@ -206,9 +206,8 @@ class Service implements ServiceBaseInterface, ServiceMutableInterface, ServiceC
         if (isset($data[self::PROPERTY_IDENTITY])) {
             $this->setIdentity($this->freshIdentity(null, $data[self::PROPERTY_IDENTITY]));
         }
-        if (isset($data[self::PROPERTY_PRIMARY_ADDRESS])) {
+        if (isset($data[self::PROPERTY_PRIMARY_ADDRESS]) && is_string($data[self::PROPERTY_PRIMARY_ADDRESS])) {
-            $value = $data[self::PROPERTY_PRIMARY_ADDRESS];
+            $this->setPrimaryAddress(new Address($data[self::PROPERTY_PRIMARY_ADDRESS]));
-            $this->setPrimaryAddress(is_array($value) ? Address::fromArray($value) : new Address((string)$value));
         }
         if (isset($data[self::PROPERTY_SECONDARY_ADDRESSES]) && is_array($data[self::PROPERTY_SECONDARY_ADDRESSES])) {
             $this->setSecondaryAddresses(array_map(
@@ -484,34 +483,17 @@ class Service implements ServiceBaseInterface, ServiceMutableInterface, ServiceC
             }
         }
 
-        if ($deleteMode === 'soft') {
+        // we need to determine if the folder being deleted is already in the trash
-            $targetMailbox = $this->mailService->collectionFetch((string) $target->collection());
+        if (str_starts_with((string) $target->collection(), (string) $deleteTargetIdentifier?->collection())) {
-            if ($targetMailbox === null) {
+            // if so, we should hard delete instead of moving to avoid duplicates in the trash
-                throw new \RuntimeException('Collection not found for delete operation');
+            $deleteMode = 'hard';
-            }
-
-            $targetIdentifier = (string) $target->collection();
-            $trashIdentifier = (string) $deleteTargetIdentifier->collection();
-            $parentIdentifier = isset($targetMailbox['parentId'])
-                ? (string) $targetMailbox['parentId']
-                : null;
-
-            // JMAP mailbox IDs are opaque, so containment must be determined
-            // from parentId rather than by comparing ID prefixes.
-            if ($targetIdentifier === $trashIdentifier || $parentIdentifier === $trashIdentifier) {
-                $deleteMode = 'hard';
-            }
         }
 
-        if ($deleteMode === 'soft') {
+        $result = match ($deleteMode) {
-            return $this->collectionMove($deleteTargetIdentifier, $target);
+            'soft' => $this->collectionMove($deleteTargetIdentifier, $target),
-        }
+            'hard' => $this->mailService->collectionDestroy($target->collection(), $force),
-
+        };
-        if ($this->mailService->collectionDestroy((string) $target->collection(), $force) === null) {
+        return $result;
-            throw new \RuntimeException("Failed to delete collection: {$target->collection()}");
-        }
-
-        return true;
     }
 
     public function collectionMove(CollectionIdentifier $target, CollectionIdentifier $source): CollectionBaseInterface
@@ -897,31 +879,7 @@ class Service implements ServiceBaseInterface, ServiceMutableInterface, ServiceC
             );
         }
 
-        $nativeProperties = $this->normalizeMessageProperties($message);
+        $nativeMessage = $this->normalizeMessageProperties($message)->toJmap();
-        $attachments = $nativeProperties->getAttachments();
-        foreach ($attachments as $attachment) {
-            if ($attachment->getBlobId() !== null) {
-                continue;
-            }
-
-            $content = $attachment->getContent();
-            if ($content === null) {
-                throw new \InvalidArgumentException(sprintf(
-                    'Attachment "%s" has neither content nor a JMAP blob identifier',
-                    $attachment->getName() ?? 'unnamed',
-                ));
-            }
-
-            $attachment->setBlobId($this->mailService->blobDeposit(
-                $attachment->getType() ?? 'application/octet-stream',
-                $content,
-            ));
-        }
-        if ($attachments !== []) {
-            $nativeProperties->setAttachments(...$attachments);
-        }
-
-        $nativeMessage = $nativeProperties->toJmap();
         $transportId = $this->mailService->entitySubmitFresh($identityId, $nativeMessage, $preSendTarget->collection(), $postSentTarget->collection());
 
         return new EntitySubmitResult(

lib/Providers/People/PeopleProvider.php

@@ -97,7 +97,7 @@ class Provider implements IProviderBase, IProviderServiceMutate
         }
 
         // Note: This simplified interface doesn't pass tenantId
-        // Will need to get it from TenantContextInterface in actual implementation
+        // Will need to get it from SessionTenant in actual implementation
         throw new \RuntimeException('Use Mail Provider interface for service creation');
     }
 

lib/Service/Remote/RemoteMailService.php

@@ -912,44 +912,23 @@ class RemoteMailService {
 	 *
 	 * @since Release 2.0.0
 	 */
-	public function entitySubmitFresh(string $identityId, array $data, string $preSendTarget, string $postSentTarget): string {
+	public function entitySubmitFresh(string $identityId, array $message, string $preSendTarget, string $postSentTarget): string {
 
-		$message = new MailParametersRequest();
+		$mail = new MailParametersRequest();
-		$message->parametersRaw($data);
+		$mail->parametersRaw($message);
 
-		$messageId = 'm_' . uniqid();
+		$messageCreateId = 'm_' . uniqid();
-		$submissionId = 's_' . uniqid();
+		$submissionCreateId = 's_' . uniqid();
 
 		$r0 = new MailSet($this->dataAccount, null, $this->resourceNamespace, $this->resourceEntityLabel);
-		$m0 = $r0->create($messageId, $message);
+		$createdMessage = $r0->create($messageCreateId, $mail);
-		$m0->in($preSendTarget);
+		$createdMessage->in($preSendTarget);
-		$m0->draft(true);
-		$m0->seen(true);
-
 		$r1 = new MailSubmissionSet($this->dataAccount, null, $this->resourceNamespace, $this->resourceEntityLabel);
-		$r1->completionUpdate('#' . $messageId, [
+		$submission = $r1->create($submissionCreateId);
-			'mailboxIds/' . $postSentTarget => true,
+		$submission->identity($identityId);
-			'mailboxIds/' . $preSendTarget => null,
+		$submission->message('#' . $messageCreateId);
-			'keywords/$draft' => null,
-		]);
-		$s0 = $r1->create($submissionId);
-		$s0->identity($identityId);
-		$s0->message('#' . $messageId);
 
 		$bundle = $this->dataStore->perform([$r0, $r1]);
-		$messageResponse = $bundle->response(0);
-		if ($messageResponse instanceof ResponseException) {
-			throw new Exception($messageResponse->type() . ': ' . $messageResponse->description(), 1);
-		}
-		if (method_exists($messageResponse, 'createFailure')) {
-			$failure = $messageResponse->createFailure($messageId);
-			if (is_array($failure)) {
-				$type = $failure['type'] ?? 'unknownError';
-				$description = $failure['description'] ?? 'Email creation failed';
-				throw new Exception($type . ': ' . $description, 1);
-			}
-		}
-
 		$response = $bundle->response(1);
 		if ($response instanceof ResponseException) {
 			if ($response->type() === 'unknownMethod') {
@@ -958,19 +937,7 @@ class RemoteMailService {
 			throw new Exception($response->type() . ': ' . $response->description(), 1);
 		}
 
-		return $this->extractSubmissionIdentifier($response, $submissionId);
+		return $this->extractSubmissionIdentifier($response, $submissionCreateId);
-	}
-
-	/**
-	 * Upload attachment content and return its JMAP blob identifier.
-	 */
-	public function blobDeposit(string $type, string $data): string {
-		$response = json_decode($this->dataStore->upload($this->dataAccount, $type, $data), true);
-		if (!is_array($response) || !isset($response['blobId']) || !is_string($response['blobId']) || $response['blobId'] === '') {
-			throw new Exception('JMAP attachment upload did not return a blob identifier', 1);
-		}
-
-		return $response['blobId'];
 	}
 
 	/**
@@ -986,18 +953,18 @@ class RemoteMailService {
 		$requests = [];
 
 		if ($patch !== null && $patch !== []) {
-			$m0 = new MailParametersRequest();
+			$draftMutation = new MailParametersRequest();
-			$m0->parametersRaw($patch);
+			$draftMutation->parametersRaw($patch);
 			$r0 = new MailSet($this->dataAccount, null, $this->resourceNamespace, $this->resourceEntityLabel);
-			$r0->update($draftId, $m0);
+			$r0->update($draftId, $draftMutation);
 			$requests[] = $r0;
 		}
 
-		$submissionId = 's_' . uniqid();
+		$submissionCreateId = 's_' . uniqid();
 		$r1 = new MailSubmissionSet($this->dataAccount, null, $this->resourceNamespace, $this->resourceEntityLabel);
-		$s0 = $r1->create($submissionId);
+		$submission = $r1->create($submissionCreateId);
-		$s0->identity($identityId);
+		$submission->identity($identityId);
-		$s0->message($draftId);
+		$submission->message($draftId);
 		$requests[] = $r1;
 
 		$bundle = $this->dataStore->perform($requests);
@@ -1010,7 +977,19 @@ class RemoteMailService {
 			throw new Exception($response->type() . ': ' . $response->description(), 1);
 		}
 
-		return $this->extractSubmissionIdentifier($response, $submissionId);
+		return $this->extractSubmissionIdentifier($response, $submissionCreateId);
+	}
+
+	private function collectionByRole(string $role): ?string {
+		$filter = $this->collectionListFilter();
+		$filter->condition('role', $role);
+
+		$collections = $this->collectionList(null, $filter, null);
+		if ($collections === []) {
+			return null;
+		}
+
+		return (string)array_key_first($collections);
 	}
 
 	private function extractSubmissionIdentifier(object $response, string $createId): string {

lib/Service/Remote/RemoteService.php

@@ -13,7 +13,7 @@ use GuzzleHttp\Client as HttpClient;
 use GuzzleHttp\Psr7\HttpFactory;
 use JmapClient\Authentication\Basic;
 use JmapClient\Client as JmapClient;
-use KTXF\Security\Crypto;
+use KTXC\Server;
 use KTXF\Resource\Provider\ResourceServiceIdentityBasic;
 use KTXF\Resource\Provider\ResourceServiceLocationUri;
 use KTXM\ProviderJmapc\Providers\Mail\Service as MailService;
@@ -73,13 +73,10 @@ class RemoteService {
 		}
 		// debugging
 		if ($service->getDebug()) {
-			$logDirectory = dirname(__DIR__, 5) . '/var/logs/jmap';
+			$logDir = Server::getInstance()?->logDir();
-			if (!is_dir($logDirectory) && !mkdir($logDirectory, 0775, true) && !is_dir($logDirectory)) {
+			$logDir .= '/jmap/' . $service->identifier() . '.json';
-				throw new \RuntimeException(sprintf('Unable to create JMAP log directory: %s', $logDirectory));
-			}
-			$logFile = $logDirectory . '/' . $service->identifier() . '.json';
 			$client->configureTransportLogState(true);
-			$client->configureTransportLogLocation($logFile);
+			$client->configureTransportLogLocation($logDir);
 		}
 		// return
 		return $client;
@@ -203,7 +200,7 @@ class RemoteService {
 		return $service;
 	}
 
-	public static function cookieStoreRetrieve(mixed $id, Crypto $crypto): ?array {
+	public static function cookieStoreRetrieve(mixed $id): ?array {
 
 		$file = sys_get_temp_dir() . DIRECTORY_SEPARATOR . (string)$id . '.jmapc';
 
@@ -212,6 +209,7 @@ class RemoteService {
 		}
 
 		$data = file_get_contents($file);
+		$crypto = Server::getInstance()->container()->get(\KTXF\Security\Crypto::class);
 		$data = $crypto->decrypt($data);
 
 		if (!empty($data)) {
@@ -222,12 +220,13 @@ class RemoteService {
 
 	}
 
-	public static function cookieStoreDeposit(mixed $id, array $value, Crypto $crypto): void {
+	public static function cookieStoreDeposit(mixed $id, array $value): void {
 
 		if (empty($value)) {
 			return;
 		}
 
+		$crypto = Server::getInstance()->container()->get(\KTXF\Security\Crypto::class);
 		$data = $crypto->encrypt(json_encode($value));
 
 		$file = sys_get_temp_dir() . DIRECTORY_SEPARATOR . (string)$id . '.jmapc';

package-lock.json

@@ -9,7 +9,7 @@
       "version": "1.0.0",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
-        "pinia": "^4.0.0",
+        "pinia": "^3.0.0",
         "vue": "^3.5.18",
         "vue-router": "^5.0.0",
         "vuetify": "^4.0.0"
@@ -1040,6 +1040,26 @@
       "integrity": "sha512-LjgdTytVFXeUgtHZr9WYViYSM/g8MkcTPYDlPa3cDqMirHjKiSZPYd6DoL7pK8AJQr+uWkQvCjHNdiMqsrJs+g==",
       "license": "MIT"
     },
+    "node_modules/@vue/devtools-kit": {
+      "version": "7.7.9",
+      "license": "MIT",
+      "dependencies": {
+        "@vue/devtools-shared": "^7.7.9",
+        "birpc": "^2.3.0",
+        "hookable": "^5.5.3",
+        "mitt": "^3.0.1",
+        "perfect-debounce": "^1.0.0",
+        "speakingurl": "^14.0.1",
+        "superjson": "^2.2.2"
+      }
+    },
+    "node_modules/@vue/devtools-shared": {
+      "version": "7.7.9",
+      "license": "MIT",
+      "dependencies": {
+        "rfdc": "^1.4.1"
+      }
+    },
     "node_modules/@vue/language-core": {
       "version": "3.3.8",
       "resolved": "https://registry.npmjs.org/@vue/language-core/-/language-core-3.3.8.tgz",
@@ -1323,6 +1343,19 @@
       "dev": true,
       "license": "MIT"
     },
+    "node_modules/copy-anything": {
+      "version": "4.0.5",
+      "license": "MIT",
+      "dependencies": {
+        "is-what": "^5.2.0"
+      },
+      "engines": {
+        "node": ">=18"
+      },
+      "funding": {
+        "url": "https://github.com/sponsors/mesqueeb"
+      }
+    },
     "node_modules/cross-spawn": {
       "version": "7.0.6",
       "dev": true,
@@ -1554,6 +1587,16 @@
       "dev": true,
       "license": "MIT"
     },
+    "node_modules/is-what": {
+      "version": "5.5.0",
+      "license": "MIT",
+      "engines": {
+        "node": ">=18"
+      },
+      "funding": {
+        "url": "https://github.com/sponsors/mesqueeb"
+      }
+    },
     "node_modules/isexe": {
       "version": "2.0.0",
       "dev": true,
@@ -2035,6 +2078,10 @@
         "node": ">=16 || 14 >=14.17"
       }
     },
+    "node_modules/mitt": {
+      "version": "3.0.1",
+      "license": "MIT"
+    },
     "node_modules/mlly": {
       "version": "1.8.2",
       "license": "MIT",
@@ -2179,6 +2226,10 @@
       "version": "2.0.3",
       "license": "MIT"
     },
+    "node_modules/perfect-debounce": {
+      "version": "1.0.0",
+      "license": "MIT"
+    },
     "node_modules/picocolors": {
       "version": "1.1.1",
       "license": "ISC"
@@ -2194,30 +2245,31 @@
       }
     },
     "node_modules/pinia": {
-      "version": "4.0.2",
+      "version": "3.0.4",
-      "resolved": "https://registry.npmjs.org/pinia/-/pinia-4.0.2.tgz",
-      "integrity": "sha512-yKVVA7bSj5oRZFp/Ab9wLlmyb5gPUYEiIm4ryiWTe/xe7PtkRdMVOp1X1ggvq0c6Uj7Q0Du1HnV2mtAwM0Ks1g==",
       "license": "MIT",
       "dependencies": {
-        "nostics": "^1.1.4"
+        "@vue/devtools-api": "^7.7.7"
       },
       "funding": {
         "url": "https://github.com/sponsors/posva"
       },
       "peerDependencies": {
-        "@vue/devtools-api": "^8.1.5",
+        "typescript": ">=4.5.0",
-        "typescript": ">=5.6.0",
         "vue": "^3.5.11"
       },
       "peerDependenciesMeta": {
-        "@vue/devtools-api": {
-          "optional": false
-        },
         "typescript": {
           "optional": true
         }
       }
     },
+    "node_modules/pinia/node_modules/@vue/devtools-api": {
+      "version": "7.7.9",
+      "license": "MIT",
+      "dependencies": {
+        "@vue/devtools-kit": "^7.7.9"
+      }
+    },
     "node_modules/pkg-types": {
       "version": "2.3.1",
       "license": "MIT",
@@ -2299,6 +2351,10 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/rfdc": {
+      "version": "1.4.1",
+      "license": "MIT"
+    },
     "node_modules/rolldown": {
       "version": "1.1.5",
       "devOptional": true,
@@ -2412,6 +2468,13 @@
         "node": ">=0.10.0"
       }
     },
+    "node_modules/speakingurl": {
+      "version": "14.0.1",
+      "license": "BSD-3-Clause",
+      "engines": {
+        "node": ">=0.10.0"
+      }
+    },
     "node_modules/stackback": {
       "version": "0.0.2",
       "dev": true,
@@ -2510,6 +2573,16 @@
         "node": ">=8"
       }
     },
+    "node_modules/superjson": {
+      "version": "2.2.6",
+      "license": "MIT",
+      "dependencies": {
+        "copy-anything": "^4"
+      },
+      "engines": {
+        "node": ">=16"
+      }
+    },
     "node_modules/supports-color": {
       "version": "7.2.0",
       "dev": true,

package.json

@@ -18,7 +18,7 @@
     "test:coverage": "vitest run --coverage --config tests/js/vitest.config.ts"
   },
   "dependencies": {
-    "pinia": "^4.0.0",
+    "pinia": "^3.0.0",
     "vue": "^3.5.18",
     "vue-router": "^5.0.0",
     "vuetify": "^4.0.0"

src/components/JmapAuthPanel.vue

@@ -274,7 +274,7 @@ async function initiateOAuth() {
         variant="outlined"
         prepend-inner-icon="mdi-account"
         class="mb-4"
-        autocomplete="off"
+        autocomplete="username"
         autocorrect="off"
         autocapitalize="none"
         :rules="[rules.required]"
@@ -289,7 +289,7 @@ async function initiateOAuth() {
         variant="outlined"
         prepend-inner-icon="mdi-lock"
         class="mb-4"
-        autocomplete="new-password"
+        autocomplete="current-password"
         :rules="[rules.required]"
       />
     </template>

src/components/JmapAuxiliaryPanel.vue

@@ -25,7 +25,7 @@ const settingGroups = [
     title: 'Addresses',
     value: 'addresses' as const,
     icon: 'mdi-at',
-    description: 'View the primary mailbox identity and sender aliases synced from the JMAP server.'
+    description: 'Configure the primary mailbox identity and any sender aliases exposed by this service.'
   },
   {
     title: 'Messages',
@@ -71,7 +71,7 @@ watch(
 )
 
 watch(
-  [deleteMode, deleteDestination],
+  [deleteMode, deleteDestination, primaryAddress, secondaryAddresses],
   () => {
     const nextService = props.service ?? new ServiceObject()
     const nextAuxiliary = {
@@ -83,9 +83,13 @@ watch(
     }
 
     if (sameAuxiliary(nextService.auxiliary ?? {}, nextAuxiliary)) {
-      return
+      if (sameAddresses(nextService)) {
+        return
+      }
     }
 
+    nextService.primaryAddress = primaryAddress.value.empty ? null : primaryAddress.value
+    nextService.secondaryAddresses = dedupeAddresses(secondaryAddresses.value)
     nextService.auxiliary = nextAuxiliary
     emit('update:service', nextService)
   },
@@ -107,10 +111,44 @@ function normalizeDeleteDestination(value: string): string {
   return trimmedValue.length > 0 ? trimmedValue : 'Trash'
 }
 
+function dedupeAddresses(entries: ServiceAddressObject[]): ServiceAddressObject[] {
+  const populated = entries.filter(entry => !entry.empty)
+  return populated.filter((entry, index) =>
+    populated.findIndex(candidate => candidate.matches(entry.address)) === index)
+}
+
+function addSecondaryAddress() {
+  secondaryAddresses.value.push(new ServiceAddressObject())
+}
+
+function removeSecondaryAddress(index: number) {
+  secondaryAddresses.value.splice(index, 1)
+}
+
+function validAddress(value: string): boolean | string {
+  const trimmedValue = value.trim()
+  return trimmedValue.length === 0 || /^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(trimmedValue) || 'Invalid email address'
+}
+
 function sameAuxiliary(current: Record<string, any>, next: Record<string, any>): boolean {
   return (current.deleteMode === 'hard' ? 'hard' : 'soft') === next.deleteMode
     && (current.deleteDestination ?? undefined) === (next.deleteDestination ?? undefined)
 }
+
+function sameAddresses(service: ServiceObject): boolean {
+  const nextPrimary = primaryAddress.value.empty ? null : primaryAddress.value
+  const nextSecondary = dedupeAddresses(secondaryAddresses.value)
+  return sameAddress(service.primaryAddress, nextPrimary)
+    && service.secondaryAddresses.length === nextSecondary.length
+    && service.secondaryAddresses.every((entry, index) => sameAddress(entry, nextSecondary[index]))
+}
+
+function sameAddress(current: ServiceAddressObject | null, next: ServiceAddressObject | null): boolean {
+  if (current === null || next === null) {
+    return current === next
+  }
+  return current.equals(next)
+}
 </script>
 
 <template>
@@ -138,57 +176,69 @@ function sameAuxiliary(current: Record<string, any>, next: Record<string, any>):
           <div class="jmap-settings-card">
             <h3 class="text-h6 mb-2">Addresses</h3>
             <p class="text-body-2 text-medium-emphasis mb-6">
-              The primary mailbox identity and sender aliases are managed by the JMAP server and synced automatically.
+              Configure the primary mailbox identity and any additional sender aliases exposed by this service.
             </p>
 
             <div class="text-subtitle-2 mb-2">Primary Address</div>
             <div class="d-flex ga-2 mb-6">
               <v-text-field
-                :model-value="primaryAddress.label"
+                v-model="primaryAddress.label"
                 label="Display Name"
                 variant="outlined"
                 density="compact"
                 hide-details="auto"
-                readonly
               />
               <v-text-field
-                :model-value="primaryAddress.address"
+                v-model="primaryAddress.address"
                 label="Email Address"
                 variant="outlined"
                 density="compact"
                 prepend-inner-icon="mdi-email-outline"
+                :rules="[validAddress]"
                 hide-details="auto"
-                readonly
               />
             </div>
 
             <div class="text-subtitle-2 mb-2">Secondary Addresses</div>
-            <p v-if="secondaryAddresses.length === 0" class="text-body-2 text-medium-emphasis">
-              No aliases reported by the server.
-            </p>
             <div
               v-for="(entry, index) in secondaryAddresses"
               :key="index"
               class="d-flex ga-2 mb-2"
             >
               <v-text-field
-                :model-value="entry.label"
+                v-model="entry.label"
                 label="Display Name"
                 variant="outlined"
                 density="compact"
                 hide-details="auto"
-                readonly
               />
               <v-text-field
-                :model-value="entry.address"
+                v-model="entry.address"
                 label="Email Address"
                 variant="outlined"
                 density="compact"
                 prepend-inner-icon="mdi-email-multiple-outline"
+                :rules="[validAddress]"
                 hide-details="auto"
-                readonly
               />
+              <v-btn
+                icon
+                size="small"
+                variant="text"
+                @click="removeSecondaryAddress(index)"
+              >
+                <v-icon>mdi-delete-outline</v-icon>
+                <v-tooltip activator="parent" location="bottom">Remove Alias</v-tooltip>
+              </v-btn>
             </div>
+
+            <v-btn
+              variant="tonal"
+              prepend-icon="mdi-plus"
+              @click="addSecondaryAddress"
+            >
+              Add Alias
+            </v-btn>
           </div>
         </v-window-item>