refactor: unify command complition checking

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>
2026-09-25 12:14:37 -04:00
parent 1b68c99521
commit 6a36e91cb4
21 changed files with 132 additions and 80 deletions
@@ -4,13 +4,13 @@ declare(strict_types=1);

 namespace KTXM\ProviderImap\Client\Protocol\Command;

+use KTXM\ProviderImap\Client\Protocol\CompletionChecker;
 use KTXM\ProviderImap\Client\Protocol\Parser\ResponseCodeParser;
 use KTXM\ProviderImap\Client\Protocol\StringEncoder;
 use KTXM\ProviderImap\Client\Result\MessageTransferResult;
 use KTXM\ProviderImap\Client\Protocol\Command\Argument\MessageTarget;
 use KTXM\ProviderImap\Client\Protocol\IdentifierMode;
 use KTXM\ProviderImap\Client\ImapException;
-use KTXM\ProviderImap\Client\CommandFailedException;
 use KTXM\ProviderImap\Client\Protocol\RequestFrame;
 use KTXM\ProviderImap\Client\Protocol\Response\TaggedResponse;
 use KTXM\ProviderImap\Client\Protocol\Response\UntaggedResponse;
@@ -114,14 +114,7 @@ final class MessageTransferCommand implements CommandInterface
                    $highestModSeq,
                );

-                if (!$response->isOk()) {
-                    throw new CommandFailedException(
-                        $this->operation,
-                        $response->status(),
-                        $response->text(),
-                        $this->responseCodeParser->parse($response->text()),
-                    );
-                }
+                CompletionChecker::assertSuccess($this->name(), $response);

                return new MessageTransferResult(
                    $response->status(),