Nodarx/people_manager
1
0
Fork 0
Code Issues 1 Pull Requests 4 Actions Projects Releases Activity

refactor: range construction

Browse Source 
Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>
This commit is contained in:
Sebastian Krupinski
2026-07-03 21:39:45 -04:00
parent e04957de5e
commit 8a5c618e5c
1 changed files with 2 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/Manager.php
+2 -28
View File
@@ -20,7 +20,6 @@ use KTXF\Resource\Filter\IFilter;
use KTXF\Resource\Identifier\CollectionIdentifier;
use KTXF\Resource\Identifier\EntityIdentifier;
use KTXF\Resource\Identifier\ResourceIdentifiers;
use KTXF\Resource\Range\RangeAnchorType;
use KTXF\Resource\Range\RangeType;
use KTXF\Resource\Sort\ISort;
use Psr\Log\LoggerInterface;
@@ -572,20 +571,7 @@ class Manager {
// construct range for entities
$entityRange = null;
if ($range !== null && $range !== [] && isset($range['type'])) {
$entityRange = $service->entityListRange(RangeType::from($range['type']));
// Cast to IRangeTally if the range type is TALLY
if ($entityRange->type() === RangeType::TALLY) {
/** @var \KTXF\Resource\Range\IRangeTally $entityRange */
if (isset($range['anchor'])) {
$entityRange->setAnchor(RangeAnchorType::from($range['anchor']));
}
if (isset($range['position'])) {
$entityRange->setPosition($range['position']);
}
if (isset($range['tally'])) {
$entityRange->setTally($range['tally']);
}
}
$entityRange = $service->entityListRange(RangeType::from($range['type']))->jsonDeserialize($range);
}
// retrieve entities for each collection
foreach ($collectionSelected as $collectionId) {
@@ -661,19 +647,7 @@ class Manager {
// construct range for entities
$entityRange = null;
if ($range !== null && $range !== [] && isset($range['type'])) {
$entityRange = $service->entityListRange(RangeType::from($range['type']));
if ($entityRange->type() === RangeType::TALLY) {
/** @var \KTXF\Resource\Range\IRangeTally $entityRange */
if (isset($range['anchor'])) {
$entityRange->setAnchor(RangeAnchorType::from($range['anchor']));
}
if (isset($range['position'])) {
$entityRange->setPosition($range['position']);
}
if (isset($range['tally'])) {
$entityRange->setTally($range['tally']);
}
}
$entityRange = $service->entityListRange(RangeType::from($range['type']))->jsonDeserialize($range);
}
// yield entities for each collection individually
foreach ($collectionSelected as $collectionId) {