refactor: code clean up

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>
This commit is contained in:
2026-07-06 22:42:31 -04:00
parent df531908f3
commit 3c0ea698b1
8 changed files with 62 additions and 66 deletions
+8 -8
View File
@@ -9,8 +9,8 @@ import {
describe('calendar visible ranges', () => {
it('uses a half-open range for a day span', () => {
const range = daysVisibleRange(new Date(2026, 5, 15, 13, 45), 7)
const start = new Date(range.startMs)
const end = new Date(range.endMs)
const start = new Date(range.start)
const end = new Date(range.end)
expect([start.getFullYear(), start.getMonth(), start.getDate(), start.getHours()])
.toEqual([2026, 5, 15, 0])
@@ -20,8 +20,8 @@ describe('calendar visible ranges', () => {
it('uses calendar-day arithmetic across a daylight-saving boundary', () => {
const range = daysVisibleRange(new Date(2026, 2, 8, 12), 1)
const start = new Date(range.startMs)
const end = new Date(range.endMs)
const start = new Date(range.start)
const end = new Date(range.end)
expect(start.getHours()).toBe(0)
expect(end.getHours()).toBe(0)
@@ -30,8 +30,8 @@ describe('calendar visible ranges', () => {
it('includes every leading and trailing day rendered by a month grid', () => {
const range = monthGridVisibleRange(new Date(2026, 5, 15))
const start = new Date(range.startMs)
const end = new Date(range.endMs)
const start = new Date(range.start)
const end = new Date(range.end)
expect([start.getFullYear(), start.getMonth(), start.getDate()]).toEqual([2026, 4, 31])
expect([end.getFullYear(), end.getMonth(), end.getDate()]).toEqual([2026, 6, 5])
@@ -39,8 +39,8 @@ describe('calendar visible ranges', () => {
it('calculates a leap-year February grid', () => {
const range = monthGridVisibleRange(new Date(2024, 1, 29))
const start = new Date(range.startMs)
const end = new Date(range.endMs)
const start = new Date(range.start)
const end = new Date(range.end)
expect([start.getFullYear(), start.getMonth(), start.getDate()]).toEqual([2024, 0, 28])
expect([end.getFullYear(), end.getMonth(), end.getDate()]).toEqual([2024, 2, 3])
+4 -4
View File
@@ -30,7 +30,7 @@ describe('entity instance expansion', () => {
)
expect(instance.durationMs).toBe(60 * 60 * 1000)
expect(new Date(instance.startMs).getHours()).toBe(9)
expect(new Date(instance.start).getHours()).toBe(9)
expect(new Date(instance.dayStartMs).getHours()).toBe(0)
expect(instance.instanceId).toBeNull()
expect(instance.multiDay).toBe(false)
@@ -54,7 +54,7 @@ describe('entity instance expansion', () => {
eventEntity('all-day', localIso(2026, 5, 20), localIso(2026, 5, 21), true),
)
const end = new Date(instance.endMs)
const end = new Date(instance.end)
expect([end.getDate(), end.getHours()]).toEqual([21, 0])
expect(new Date(instance.dayStartMs).getDate()).toBe(20)
expect(instance.multiDay).toBe(false)
@@ -65,9 +65,9 @@ describe('entity instance expansion', () => {
eventEntity('utc-all-day', '2025-03-27T00:00:00+00:00', '2025-03-28T00:00:00+00:00', true),
)
const start = new Date(instance.startMs)
const start = new Date(instance.start)
expect([start.getMonth(), start.getDate(), start.getHours()]).toEqual([2, 27, 0])
expect(new Date(instance.endMs).getDate()).toBe(28)
expect(new Date(instance.end).getDate()).toBe(28)
})
it('gives a zero-duration event a queryable minimum duration', () => {
+8 -8
View File
@@ -39,7 +39,7 @@ describe('daily recurrence', () => {
daysVisibleRange(new Date(2026, 5, 4), 6),
)
expect(instances.map(instance => new Date(instance.startMs).getDate())).toEqual([5, 7, 9])
expect(instances.map(instance => new Date(instance.start).getDate())).toEqual([5, 7, 9])
expect(instances.every(instance => instance.durationMs === 60 * 60 * 1000)).toBe(true)
expect(new Set(instances.map(instance => instance.key)).size).toBe(3)
})
@@ -71,7 +71,7 @@ describe('daily recurrence', () => {
daysVisibleRange(new Date(2026, 5, 1), 5),
)
expect(instances.map(instance => new Date(instance.startMs).getDate())).toEqual([1, 2, 3])
expect(instances.map(instance => new Date(instance.start).getDate())).toEqual([1, 2, 3])
})
it('preserves local wall-clock time across daylight-saving changes', () => {
@@ -85,7 +85,7 @@ describe('daily recurrence', () => {
daysVisibleRange(new Date(2026, 2, 7), 3),
)
expect(instances.map(instance => new Date(instance.startMs).getHours())).toEqual([9, 9, 9])
expect(instances.map(instance => new Date(instance.start).getHours())).toEqual([9, 9, 9])
})
it('preserves exclusive calendar-day duration for recurring timeless events', () => {
@@ -107,9 +107,9 @@ describe('daily recurrence', () => {
)
expect(instances).toHaveLength(3)
expect(instances.map(instance => new Date(instance.startMs).getHours())).toEqual([0, 0, 0])
expect(instances.map(instance => new Date(instance.start).getHours())).toEqual([0, 0, 0])
expect(instances.map(instance => {
const end = new Date(instance.endMs)
const end = new Date(instance.end)
return [end.getDate(), end.getHours()]
})).toEqual([[8, 0], [9, 0], [10, 0]])
})
@@ -128,7 +128,7 @@ describe('weekly recurrence', () => {
daysVisibleRange(new Date(2026, 5, 1), 10),
)
expect(instances.map(instance => new Date(instance.startMs).getDate())).toEqual([1, 3, 8, 10])
expect(instances.map(instance => new Date(instance.start).getDate())).toEqual([1, 3, 8, 10])
})
})
@@ -150,7 +150,7 @@ describe('recurrence mutations', () => {
daysVisibleRange(new Date(2026, 5, 1), 3),
)
expect(instances.map(instance => new Date(instance.startMs).getDate())).toEqual([1, 3])
expect(instances.map(instance => new Date(instance.start).getDate())).toEqual([1, 3])
})
it('moves and restyles a modified occurrence without duplicating it', () => {
@@ -178,7 +178,7 @@ describe('recurrence mutations', () => {
const moved = instances.find(instance => instance.instanceId === sourceId)
expect(instances).toHaveLength(2)
expect(new Date(moved!.startMs).getHours()).toBe(14)
expect(new Date(moved!.start).getHours()).toBe(14)
expect(moved!.durationMs).toBe(2 * 60 * 60 * 1000)
expect(moved!.label).toBe('Moved standup')
expect(moved!.color).toBe('#abcdef')