fix: test hang

Signed-off-by: Sebastian Krupinski <krupinski01@gmail.com>

.github/workflows/test.yml

@@ -175,13 +175,26 @@ jobs:
         with:
           persist-credentials: false
 
-      - name: Verify base modules require PHP
+      - name: Expect failure when install-base-modules is set without install-php
+        id: expect-failure
+        continue-on-error: true
+        uses: ./
+        with:
+          install-node: 'true'
+          install-base-modules: 'true'
+          server-path: './test-server'
+          server-repository: ${{ env.TEST_SERVER_REPOSITORY }}
+          server-ref: ${{ env.TEST_SERVER_REF }}
+          github-server-url: ${{ env.TEST_GIT_SERVER_URL }}
+          checkout-token: ${{ secrets.TEST_SERVER_TOKEN }}
+
+      - name: Verify the action failed
         run: |
-          if bash ./scripts/validate-inputs.sh true false false true; then
-            echo "::error::Expected validation to fail when install-base-modules is set without install-php"
+          if [ "${{ steps.expect-failure.outcome }}" != "failure" ]; then
+            echo "::error::Expected action to fail when install-base-modules is set without install-php"
             exit 1
           fi
-          echo "✓ Validation correctly rejected install-base-modules without install-php"
+          echo "✓ Action correctly rejected install-base-modules without install-php"
 
   test-nginx:
     name: Test nginx

action.yml

@@ -123,12 +123,20 @@ runs:
       shell: bash
       run: |
         echo "::group::Validating inputs"
+        
+        # Validate at least one component is enabled
+        if [ "${{ inputs.install-node }}" != "true" ] && \
+           [ "${{ inputs.install-php }}" != "true" ] && \
+           [ "${{ inputs.install-nginx }}" != "true" ]; then
+          echo "::error::At least one component must be enabled (install-node, install-php, or install-nginx)"
+          exit 1
+        fi
 
-        bash "${{ github.action_path }}/scripts/validate-inputs.sh" \
-          "${{ inputs.install-node }}" \
-          "${{ inputs.install-php }}" \
-          "${{ inputs.install-nginx }}" \
-          "${{ inputs.install-base-modules }}"
+        # install-base-modules requires PHP (it runs bin/console)
+        if [ "${{ inputs.install-base-modules }}" == "true" ] && [ "${{ inputs.install-php }}" != "true" ]; then
+          echo "::error::install-base-modules requires install-php to be 'true'"
+          exit 1
+        fi
 
         echo "Server path: ${{ inputs.server-path }}"
         echo "Components to install:"

scripts/validate-inputs.sh

@@ -1,20 +0,0 @@
-#!/usr/bin/env bash
-
-set -euo pipefail
-
-install_node="${1:-false}"
-install_php="${2:-false}"
-install_nginx="${3:-false}"
-install_base_modules="${4:-false}"
-
-if [ "$install_node" != "true" ] &&
-   [ "$install_php" != "true" ] &&
-   [ "$install_nginx" != "true" ]; then
-  echo "::error::At least one component must be enabled (install-node, install-php, or install-nginx)"
-  exit 1
-fi
-
-if [ "$install_base_modules" = "true" ] && [ "$install_php" != "true" ]; then
-  echo "::error::install-base-modules requires install-php to be 'true'"
-  exit 1
-fi